Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Use Helm instead of Docker #10897

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 29, 2024

Summary

  • Swap out docker for k3s for rancher host when running e2e tests

Occurred changes and/or fixed issues

  • Currently e2e tests run the all-in-one docker image of -head
  • Change this to instead to install rancher with helm to k3s
  • This might resolve the following
    • General rancher performance is impacted by the overhead of running docker and within it the k3s that runs rancher
    • Using helm instead of docker might resolve the rancher-webhook service errors

Technical notes summary

  • we use the sslip.io magic domain
  • this does add on about 50 seconds per e2e matrix run (it takes longer to install pre-reqs plus actual install then just docker run

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.9.0 milestone Apr 29, 2024
@richard-cox richard-cox self-assigned this Apr 29, 2024
@richard-cox richard-cox force-pushed the e2e-k3s branch 15 times, most recently from 30d85eb to 41889fb Compare May 1, 2024 16:33

# Image version
# RANCHER_IMG_VERSION=v2.9-c9be13b09329bbee60a5f6419d500198f83c44d1-head
RANCHER_IMG_VERSION=v2.9-head
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be passed in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants