Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use org runners for workflows that run in PR gates #11616

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Use org runners for workflows that run in PR gates #11616

wants to merge 15 commits into from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Aug 9, 2024 •
edited
Loading

Summary

Use Org runners in PR gate workflows

Occurred changes and/or fixed issues

  • Containerised runners
    • Use these where we can (quicker, more lightweight
    • Container used bci node based
    • Note - will contain node and therefor corepack
    • Note - downside... image we run on contain node version, no version smarts
  • Non-containerised runners
    • Use these in two places
      • check-plugin-gates
        • gets resource starved on containerised runners
      • e2e tests
        • cannot run rancher in container in a containerised runner
    • Noticed these now have apt access, which could improve the yarn install
  • Added generic Setup Node action

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Aug 9, 2024
@richard-cox richard-cox changed the title wip Use org runners for test workflow Aug 9, 2024
@richard-cox richard-cox force-pushed the gh-org-runners branch 2 times, most recently from baafc57 to b724841 Compare August 9, 2024 11:13
@richard-cox richard-cox changed the title Use org runners for test workflow Use org runners for workflows run in PR gates Aug 9, 2024
@richard-cox richard-cox changed the title Use org runners for workflows run in PR gates Use org runners for workflows that run in PR gates Aug 9, 2024
@richard-cox richard-cox force-pushed the gh-org-runners branch 2 times, most recently from 448d76f to 9d25af9 Compare August 9, 2024 15:57
@richard-cox richard-cox force-pushed the gh-org-runners branch 4 times, most recently from 6f2f0dc to 459ceed Compare September 6, 2024 12:14
@richard-cox richard-cox marked this pull request as ready for review September 6, 2024 13:03
@richard-cox richard-cox force-pushed the gh-org-runners branch 4 times, most recently from 4f6dc0b to 4cc379e Compare October 25, 2024 10:28
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Oct 29, 2024
@richard-cox richard-cox force-pushed the gh-org-runners branch 4 times, most recently from 4980f46 to 3ab2f16 Compare October 31, 2024 19:39
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac Awaiting requested review from nwmac

At least 1 approving review is required to merge this pull request.

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac