add support for additional rancher helm repos #11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
6 times, most recently
from
e545d49
to
122e608
Compare
rancher-max
reviewed
Sep 11, 2024
|
@yonasberhe23 I'll check with you offline a job run. I don't need to check if the test pass only if they were triggered. |
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
122e608
to
00feb82
Compare
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
00feb82
to
8bf40f0
Compare
rancher-max
previously approved these changes
Sep 11, 2024
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
13 times, most recently
from
f71c11b
to
0dc940f
Compare
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
15 times, most recently
from
a3d2908
to
c6e54b4
Compare
|
Looking good but we have to coordinate merging this with the corral PR, as they depend on each other |
izaac
previously approved these changes
Sep 20, 2024
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
c6e54b4
to
c7eb6fd
Compare
rancher-max
previously approved these changes
Sep 24, 2024
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
c7eb6fd
to
6155735
Compare
yonasberhe23
dismissed stale reviews from rancher-max and izaac
via
368ccd1
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
6155735
to
368ccd1
Compare
yonasberhe23
force-pushed
the
add_rancher_repo_support_init
branch
from
368ccd1
to
75ef453
Compare
rancher-max
approved these changes
Sep 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #rancher/qa-tasks#1518
depends on jenkins-job-builder pr and rancherlabs/corral-packages#63
Checklist