Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue3: Several issues on Pod detail view #11980

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Sep 20, 2024

Summary

Fixes #11905

Occurred changes and/or fixed issues

  • Fix spacing issue in deployments restart count in Masthead
  • Fix extra Namespace column in the table for pods in workloads detail view (check example fleet-controller deployment via workloads list -> detail view)

Technical notes summary

1. Extra editor tab -> no need to fix, as per #11905 (comment)

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.10.0 milestone Sep 20, 2024
@aalves08 aalves08 self-assigned this Sep 20, 2024
@aalves08 aalves08 marked this pull request as ready for review September 23, 2024 09:30
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the namespace column in master. I only see it in workload detail views, not pod. It looks related to this line:
https://github.com/rancher/dashboard/blame/master/shell/detail/workload/index.vue#L200

In 2.9 this simple equality check works; maybe something changed in type-map/headersFor in the 2.10 timeframe such that the namespace column returned by the action in this component is no longer a reference to the same object imported as NAMESPACE_COL. One solution would be to compare keys on the header objects:

return this.$store.getters['type-map/headersFor'](this.podSchema).filter((h) => !h.name || h.name !== NAMESPACE_COL.name)

Happy to split this off into a separate issue if that makes more sense to you @aalves08 . The styling change in this PR LGTM

@aalves08
Copy link
Member Author

@mantis-toboggan-md thanks for catching that part of the NAMESPACE col. It's now fixed on this PR

@aalves08 aalves08 merged commit 1e32c3e into rancher:master Sep 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several issues on Pod detail view
2 participants