Ensure fetch is not called when navigating backwards #11986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11931
The issue was caused due to a watch on the
$route.query
object, when that changed we would call$fetch
a second time before leaving the page.Occurred changes and/or fixed issues
Added a condition to check for an empty query object before calling
$fetch
Technical notes summary
When navigating backwards (from
apps/charts/chart
toapps/charts
) the query object is empty, the watch is still used when the route contains the query, e.g. when selecting a different version from the Readme view.Areas or cases that should be tested
apps/charts
Areas which could experience regressions
Screenshot/Video
2024-09-20.13-52-58.mp4
Checklist