Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue3: CIS Benchmark issues #11991

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

aalves08
Copy link
Collaborator

@aalves08 aalves08 commented Sep 23, 2024

Summary

Fixes #11911, #11915 => ( epic #11799 )

Occurred changes and/or fixed issues

  • modify clusterscan model to apply defaults on edit/create view instead of model because of schema diet changes ( v1/schemaDefinitions information is not available when hard refreshing the edit/create/detail views)
  • add missing translations in clusterscan edit view
  • fix broken links in clusterscan and clusterscanprofile

Technical notes summary

Areas or cases that should be tested

  • Install CIS Benchmark cluster tool helm chart
    Cluster --> Tools --> install CIS Benchmark --> refresh
  • Check all resource views in CIS Benchmark ( clusterscan, clusterscanprofile, clusterscanbenchmark)

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…in clusterscan + update clusterscan model to apply defaults on edit/create view instead of model because of schema diet changes
@aalves08 aalves08 added this to the v2.10.0 milestone Sep 23, 2024
@aalves08 aalves08 self-assigned this Sep 23, 2024
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor comment, otherwise looks good

shell/edit/cis.cattle.io.clusterscan.vue Outdated Show resolved Hide resolved
@aalves08
Copy link
Collaborator Author

@richard-cox up for re-review. Made the change from mode to realMode

@aalves08 aalves08 merged commit 4c756e9 into rancher:master Sep 26, 2024
30 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
* add missing translations in clusterscan edit view + fix broken links in clusterscan + update clusterscan model to apply defaults on edit/create view instead of model because of schema diet changes

* change mode for realMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIS Benchmark: Refresh on scan detail pages gives full page (dev) error
2 participants