Simplify InputOrDisplay.vue component #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in Harvester Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
harvester-fixes
branch
from
0cd927b
to
afe4811
Compare
rak-phillip
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This change looks good to me.
To be clear about the issue, this is related to Slot Unification in Vue 3 now exposing slots as a function1:
I left a comment on an alternative approach, but I think that we should ultimately use the solution that will be easiest to understand for future maintenance.
Footnotes
| h('div', { class: 'value' }, slots.value ? slots.value : displayValue.value) | ||
| ]); | ||
| } else { | ||
| return slots.default; |
There was a problem hiding this comment.
Alternatively, we could have invoked the slot as a function via:
return slots.default();
The same would go for the two slots above.
There was a problem hiding this comment.
Thanks Phil, better to know what the error was, I found another case where we need to update the slots API. #12005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Harvester, we have some errors when using the
InputOrDisplaycomponent as a container - probably something related to the use ofsetupfunction or dynamic HTML build.https://github.com/torchiaf/harvester/blob/62da7658669d156d63b0d385a2978ab9d37637de/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineCpuMemory.vue#L81-L94
The current PR just simplify the implementation and fixes the issue.
After