Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translation for OVHCloud Managed Kubernetes Service #12021

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

belgaied2
Copy link
Contributor

@belgaied2 belgaied2 commented Sep 25, 2024

Signed-off-by: Mohamed Belgaied Hassine belgaied2@hotmail.com

Summary

This PR adds a translation for ovhcloudmks kontainer driver, so that it can show correctly OVHcloud MKS in the UI.

Occurred changes

Adds 2 lines with a mapping ovhcloudmks: OVHCloud MKS in the translation yaml files.

Technical notes summary

Simple

Areas or cases that should be tested

Nothing in particular, OVH will test this.

Areas which could experience regressions

Risk is extremely low for regressions

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • tests are not needed
  • there are no UX changes

Signed-off-by: Mohamed Belgaied Hassine <belgaied2@hotmail.com>
@belgaied2 belgaied2 changed the title Master Adding translation for OVHCloud Managed Kubernetes Service Sep 25, 2024
@belgaied2 belgaied2 added this to the v2.8.9 milestone Sep 25, 2024
Copy link
Collaborator

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM @belgaied2

One thing to notice is that if the milestone is correct 2.8.9, then you'll need to redo this PR against the branch release-2.8 as master is currently tracking this upcoming release of 2.10.

We should also backport it for 2.9 -> branch release-2.9

FYI @richard-cox

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Alex's comment i've updated the milestone to 2.10 as it tracks master.

For 2.9 the change needs to be backported to release-2.9.

For 2.8 the change needs to be backported to release-2.8.

@belgaied2 Would you be able to confirm any translations when provisioning a hosted cluster using this provider are correct? I'm not 100% sure but there might need to be similar changes in rancher/ui

@richard-cox
Copy link
Member

SURE-9091

@belgaied2
Copy link
Contributor Author

I got the information from OVHcloud that it works correctly (at least for the Create Cluster View, I do not know more details) if they rebuild the Rancher container image. I did not test myself however.
Seeing the structure of rancher/ui translations, it might be that credentials also need additional custom translations, but I am not sure. I will have to check with them.

@mantis-toboggan-md mantis-toboggan-md merged commit ab2fbd0 into rancher:master Sep 28, 2024
30 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
…ncher#12021)

Signed-off-by: Mohamed Belgaied Hassine <belgaied2@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants