-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding translation for OVHCloud Managed Kubernetes Service #12021
Conversation
Signed-off-by: Mohamed Belgaied Hassine <belgaied2@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM @belgaied2
One thing to notice is that if the milestone is correct 2.8.9
, then you'll need to redo this PR against the branch release-2.8
as master
is currently tracking this upcoming release of 2.10
.
We should also backport it for 2.9 -> branch release-2.9
FYI @richard-cox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per Alex's comment i've updated the milestone to 2.10 as it tracks master
.
For 2.9 the change needs to be backported to release-2.9.
For 2.8 the change needs to be backported to release-2.8.
@belgaied2 Would you be able to confirm any translations when provisioning a hosted cluster using this provider are correct? I'm not 100% sure but there might need to be similar changes in rancher/ui
SURE-9091 |
I got the information from OVHcloud that it works correctly (at least for the |
…ncher#12021) Signed-off-by: Mohamed Belgaied Hassine <belgaied2@hotmail.com>
Signed-off-by: Mohamed Belgaied Hassine belgaied2@hotmail.com
Summary
This PR adds a translation for
ovhcloudmks
kontainer driver, so that it can show correctlyOVHcloud MKS
in the UI.Occurred changes
Adds 2 lines with a mapping ovhcloudmks: OVHCloud MKS in the translation yaml files.
Technical notes summary
Simple
Areas or cases that should be tested
Nothing in particular, OVH will test this.
Areas which could experience regressions
Risk is extremely low for regressions
Checklist