Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify that an array list is required #12024

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Sep 25, 2024

Summary

This is in support of Harvester. The forked version of ArrayListSelect was using this field in this way:
image

Areas or cases that should be tested

You can add the required field to any array list which has a title.

Areas which could experience regressions

Shouldn't be any. Respects the existing default of false.

Screenshot/Video

This change adds the exact same visual that was present in harvester even though I don't love it:
arraylist-required

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@codyrancher codyrancher added this to the v2.10.0 milestone Sep 25, 2024
@codyrancher codyrancher added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Sep 25, 2024
@codyrancher codyrancher marked this pull request as ready for review September 26, 2024 00:03
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds the exact same visual that was present in harvester even though I don't love it:

Yeah, I don't love it either.. since this is an existing implementation, I think that we make do with what we have and enhance later.

@codyrancher codyrancher merged commit f1dce33 into rancher:master Sep 27, 2024
38 checks passed
@codyrancher codyrancher deleted the required-array-list branch September 27, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants