Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for supported API version annotation when loading extensions #12037

Closed
wants to merge 1 commit into from

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Sep 26, 2024

Summary

Fixes #11695

Occurred changes and/or fixed issues

  • Replaced the environment variable injection for UI_EXTENSIONS_API_VERSION in vue.config.js
  • Updated the condition to load an extension based on the extensions api version annotation
    • Now when an extension does not contain the catalog.cattle.io/ui-extensions-version annotation it will now be considered a legacy extension, and will not be loaded
    • This annotation will now be required for Vue3 extensions and will need to have a version >= 3.0.0
  • Added a small method to coerce the UI_EXTENSIONS_API_VERSION to remove any pre-release modifiers

Areas or cases that should be tested

  • Load an extension with the required API version >= 3.0.0
  • Load an extension with the required API version >= 2.0.0
  • Load an extension without the catalog.cattle.io/ui-extensions-version annotation

Areas which could experience regressions

Screenshot/Video

1
2

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@jordojordo jordojordo added kind/bug area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Sep 26, 2024
@jordojordo jordojordo added this to the v2.10.0 milestone Sep 26, 2024
@jordojordo jordojordo self-assigned this Sep 26, 2024
@aalves08
Copy link
Member

Would recommend closing this in favor of #12071

@aalves08 aalves08 closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Installed extensions throw unhandled exception
2 participants