Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom chart steps feature #12044

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 26, 2024

Summary

This removes the ability to add custom steps while installing charts.

Several issues with this feature were uncovered while reviewing #12010. Most notably, custom steps would fail to render if specific top-level variables (label, subtext) weren't defined. Since this feature does not appear to be in active use, we decided to remove it at this point.

Fixes #11898

Occurred changes and/or fixed issues

  • Remove the ability to add custom chart steps
  • Add markRaw to dynamically rendered component to prevent Vue from warning about adding reactivity to components that don't need it

Areas or cases that should be tested

  • Installing charts

Areas which could experience regressions

  • Installing charts

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip added this to the v2.10.0 milestone Sep 26, 2024
@rak-phillip rak-phillip self-assigned this Sep 26, 2024
@rak-phillip rak-phillip changed the title Remove custom chart steps Remove custom chart steps feature Sep 26, 2024
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip merged commit 1b6e64e into rancher:master Sep 27, 2024
30 checks passed
@rak-phillip rak-phillip deleted the bugfix/11898-remove-chart-steps branch September 27, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Additional install/upgrade chart steps fail to load
2 participants