Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new ButtonMultiAction.vue component #12045

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 26, 2024

Summary

This creates a new button component, ButtonMultiAction.vue, and replaces two targeted instances to address styling issues with Projects/Namespaces.

There are other instances that can be replaced, but they have been left untouched to limit the scope of this change.

Fixes #12007

Occurred changes and/or fixed issues

  • Create new component, ButtonMultiAction.vue
  • Replace in-table multi action button
  • Replace in-table multi action button in shell/components/ExplorerProjectsNamespaces.vue

Technical notes summary

While investigating the issue, it became clear that there is a difference between how scoped styles are applied to slot content in Vue3 when compared to previous versions of Vue. Looking at the similarities between the two implementations told me that a component could be created.

An alternative approach would be to duplicate the class in shell/components/ExplorerProjectsNamespaces.vue.

Relying on unscoped styles is another option, but I prefer the component-driven approach.

Areas or cases that should be tested

  • Projects/Namespaces
  • Sortable Table

Areas which could experience regressions

  • Projects/Namespaces
  • Sortable Table

Screenshot/Video

This PR

image

v2.9

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip marked this pull request as ready for review September 26, 2024 23:29
@rak-phillip rak-phillip changed the title Bugfix/12007 menu action Create new ButtonMultiAction.vue component Sep 26, 2024
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative to pick the issue up and use the composition API connotation 🥇
I added a comment but it's intended in a conversational manner, not a blocker.

LGTM

shell/components/ButtonMultiAction.vue Show resolved Hide resolved
@rak-phillip rak-phillip merged commit 66744de into rancher:master Sep 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project/Namespace menu action is not borderless
2 participants