Create new ButtonMultiAction.vue
component
#12045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This creates a new button component,
ButtonMultiAction.vue
, and replaces two targeted instances to address styling issues with Projects/Namespaces.There are other instances that can be replaced, but they have been left untouched to limit the scope of this change.
Fixes #12007
Occurred changes and/or fixed issues
ButtonMultiAction.vue
shell/components/ExplorerProjectsNamespaces.vue
Technical notes summary
While investigating the issue, it became clear that there is a difference between how scoped styles are applied to slot content in Vue3 when compared to previous versions of Vue. Looking at the similarities between the two implementations told me that a component could be created.
An alternative approach would be to duplicate the class in
shell/components/ExplorerProjectsNamespaces.vue
.Relying on unscoped styles is another option, but I prefer the component-driven approach.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
This PR
v2.9
Checklist