Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward-port PRs 11997 and 12018 #12046

Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Sep 27, 2024

Summary

Fixes #12001

Forward-port of PRs #11997 and #12018

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

To test on a 2.9 and 2.10 systems

  • Add the ui-plugin-examples repo -> branch main and make sure that messages in the extension card and slide-in panel buttons are matching the annotations for that repo
  • Add the elemental-ui repo -> branch gh-pages and make sure that messages in the extension card and slide-in panel buttons are matching the annotations for that repo

Areas which could experience regressions

Screenshot/Video

2.9
Screenshot 2024-09-27 at 10 42 19
Screenshot 2024-09-27 at 10 42 25

2.10
Screenshot 2024-09-27 at 10 44 59
Screenshot 2024-09-27 at 10 45 07

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aalves08 aalves08 merged commit eb42668 into rancher:master Sep 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants