Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct key for version info assigment #12063

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 27, 2024

Summary

This corrects the key used for version info assignment from chartName to a computed property name. This regression was introduced during the initial Vue3 migration push while attempting to get a functional RKE2 provisioning1

This also corrects keys that were incorrectly replaced at the time.

Fixes #12016

Occurred changes and/or fixed issues

  • Update all invalid instances where set was replace and a computed property name should have been used

Technical notes summary

  • We might want to double-check the linked commit1 for any other instances that might have been overlooked

Areas or cases that should be tested

  • RKE2 cluster provisioning (instructions in linked issue)

Areas which could experience regressions

  • RKE2 cluster provisioning

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Footnotes

  1. https://github.com/rancher/dashboard/commit/31646c2eae647c090accdc1e777f247779f6cc6f#diff-6836ab4af70ed1f33db60d2de9a0087b636d7604c3f1cf6bb6525f50f16a69aeR1544 2

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip added this to the v2.10.0 milestone Sep 27, 2024
@rak-phillip rak-phillip self-assigned this Sep 27, 2024
@rak-phillip rak-phillip merged commit 0ac340e into rancher:master Sep 28, 2024
39 checks passed
@cnotv cnotv mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RKE2 Add-on config does not display
2 participants