Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vue3: Installed extensions throw unhandled exception #12071

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Sep 30, 2024

Summary

Fixes #11695

Occurred changes and/or fixed issues

  • Add missing connection in vue.config to allow population of process.env.UI_EXTENSIONS_API_VERSION variable
  • Add proxy for /version endpoint in vue.config
  • Remove duplicated mechanism of error display in slide-in extensions panel for details PluginInfoPanel
  • Add default fallback for ui-extensions-version annotation to be >= 3.0.0
  • Make watches in uniplugins/index.vue as deep: true in order to reconnect proper triggers for reload banner and status update that were lost with the Vue3 migration
  • Remove “duplicate” check for kube version that wasn’t preventing loading of extension but simply informing the user that it wasn’t compatible in uniplugins/index.vue
  • Move /rancherversion network request to shell/plugins/plugin where loading order for extensions in order to correctly populate the rancher version for shouldNotLoadPlugin check
  • Add /version network request to shell/plugins/plugin in order to correctly populate the kube version for shouldNotLoadPlugin check

Technical notes summary

Areas or cases that should be tested

  • Load an extension with the required API version >= 3.0.0
  • Load an extension with the required API version >= 2.0.0
  • Load an extension without the catalog.cattle.io/ui-extensions-version annotation

Areas which could experience regressions

Screenshot/Video

Deprecated error banner in slide-in panel
Screenshot 2024-09-27 at 12 08 16
Output of /version endpoint
Screenshot 2024-09-30 at 09 38 50
**Error display with loading prevented - shouldNotLoadPlugin check **
Screenshot 2024-09-30 at 09 40 43
Screenshot 2024-09-30 at 16 04 41

Warning display when there's a newer version of an extension BUT it's not compatible
Screenshot 2024-09-30 at 11 05 37
Screenshot 2024-09-30 at 16 03 38

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 force-pushed the 12037-defaults-extensions-api-version-checks branch from 31e568f to 43048a2 Compare September 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Installed extensions throw unhandled exception
2 participants