Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor node detail e2e test to use detail page po #12074

Merged
merged 1 commit into from
Sep 30, 2024
Merged

refactor node detail e2e test to use detail page po #12074

merged 1 commit into from
Sep 30, 2024

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11815 (comment)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md added this to the v2.10.0 milestone Sep 30, 2024
izaac
izaac approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mantis-toboggan-md mantis-toboggan-md merged commit e5c4051 into rancher:master Sep 30, 2024
32 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
@mantis-toboggan-md @nwmac
refactor node detail test to use detail page po (rancher#12074)
152e27e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@mantis-toboggan-md mantis-toboggan-md

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Vue3: Node Detail Page: Refresh shows edit page instead, errors in console
2 participants
@mantis-toboggan-md @izaac