Enabling several E2E tests that were disabled for the vue3 migration #12354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
changed the title
codyrancher
commented
Oct 28, 2024
| const rancherLogo = '/img/rancher-logo.66cf5910.svg'; | ||
| const suseRancherLogo = '/img/rancher-logo.055089a3.svg'; | ||
| it('can update ui-brand', { tags: ['@globalSettings', '@adminUser'] }, () => { | ||
| // We probably want a better way to distinguish between rancher and suse logos. I'm doing this as part of the vue3 migration and trying to keep things as similar as possible. |
There was a problem hiding this comment.
The hashes were changing between both my localhost instance and the cypress tests. It didn't seem like we could rely on the hashes anymore.
There was a problem hiding this comment.
Yeah, I could definitely see how the vue3 migration might be a scenario that could cause the hash to change. It's probably best that we don't rely on the hashes for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Technical notes summary
$route had a circular reference so I added it to a list of other fields that shouldn't be serialized.
Areas or cases that should be tested
The tests are doing that already
Areas which could experience regressions
None
Screenshot/Video
Checklist