Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Harvester extension, add installation info #12414

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Oct 29, 2024

Summary

Fixes #12322

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

The Harvester extension and extension's repo are not yet available.
To test the functionality, just change the related IDs in dev:

export const HARVESTER_REPO = 'harvester-ui-extension';
export const HARVESTER_EXTENSION = 'harvester';

Areas which could experience regressions

Screenshot/Video

New Installation info - admin

image

New Installation info - standard user

image

Full view

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added this to the v2.10.0 milestone Oct 29, 2024
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@a110605 a110605 self-requested a review October 30, 2024 03:24
Copy link
Contributor

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is good.

I would suggest to add hyperlink https://github.com/harvester/harvester-ui-extension.git on the word Harvester repository or directly display https://github.com/harvester/harvester-ui-extension.git in the first point.

As a Rancher user, I don't know what's harvester extension and where is its github repository.

@torchiaf
Copy link
Member Author

@nwmac I agree with Andy to add the link to the harvester GitHub repository and possibly improve the spelling. WDYT ?

@torchiaf
Copy link
Member Author

torchiaf commented Oct 31, 2024

@a110605 I've updated the text and add the link to harvester repo

image

@torchiaf torchiaf requested a review from a110605 October 31, 2024 09:50
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
a110605
a110605 previously approved these changes Oct 31, 2024
Copy link
Contributor

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Copy link
Collaborator

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test and after adding the repo I got:
Screenshot 2024-10-31 at 16 29 57

After mimicking the install by changing the variable mentioned in the instructions to an installed extension (ex: elemental):

Screenshot 2024-10-31 at 16 42 15

I would say that LGTM

@torchiaf torchiaf merged commit ee7654c into rancher:master Oct 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtualization Management, support for Harvester extension
4 participants