-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Harvester extension, add installation info #12414
Conversation
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is good.
I would suggest to add hyperlink https://github.com/harvester/harvester-ui-extension.git on the word Harvester repository
or directly display https://github.com/harvester/harvester-ui-extension.git in the first point.
As a Rancher user, I don't know what's harvester extension and where is its github repository.
@nwmac I agree with Andy to add the link to the harvester GitHub repository and possibly improve the spelling. WDYT ? |
@a110605 I've updated the text and add the link to harvester repo |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
61e43e2
to
831d1be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #12322
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
The Harvester extension and extension's repo are not yet available.
To test the functionality, just change the related IDs in dev:
Areas which could experience regressions
Screenshot/Video
New Installation info - admin
New Installation info - standard user
Full view
Checklist