[WIP] Fix issues with iFramed cluster pages #12548
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 open issues all related to rendering the wrong iframed Ember page, or rendering the page with missing content:
#12506
#12541
possibly #12339
The code used to determine which component to render when editing any given type of cluster is convoluted. There are inexplicable mappings required to keep iframed ember pages functional (why must aks map to azureaks? why is the provider query param sometimes import and sometimes imported? Why is there an importProvider query param not used on imported clusters?) I am not even sure the above 3 issues have exactly the same root cause, but this area of dashboard code is so convoluted and prone to churn, I think they need to be addressed in tandem.
I think the above bugs came in via some combination of this and this PR. Limiting the scope of those changes seems to address #12506 and #12541 but not fully #12339 ( with this PR, I see the ember page as expected, but the 'mode' is wrong, create button shown instead of save)
Because I think the bugs are conntected to ember query params, I've collected data on the fields used to generate those query params, and what those query params are in 2.9-head ember standalone world - ember standalone has been removed from 2.10 but we can assume that these are the correct params the dashboard should be passing to ember. All below fields are on the relevant management cluster object, not the provisioning cluster object. If providerForEmberParam needs to be fixed, we need to verify that given the below status/config fields, the correct
provider
andimportProvider
query params are still set in every scenario.* undefined => an iframed page should be used for this cluster, but this query param should be present; n/a=>iframed ember pages should not be used for this cluster
** need to find out what this cluster actually is
Regarding ovh, once I get the right page to render I am seeing a console error that could be related