Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registration updates #478

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Jul 11, 2023

Ignore this PR.
Things happened.

- Store emulated TPM seed for future registrations
- Exit with error code in case of failures (systemd will manage restarts)
- Remove support for multiple configuration files
@github-actions github-actions bot added area/operator operator related changes area/register register related changes labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.92 ⚠️

Comparison is base (07dfe06) 50.09% compared to head (44973e0) 49.18%.

❗ Current head 44973e0 differs from pull request most recent head 454b97c. Consider uploading reports for the commit 454b97c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   50.09%   49.18%   -0.92%     
==========================================
  Files          37       38       +1     
  Lines        4873     4953      +80     
==========================================
- Hits         2441     2436       -5     
- Misses       2235     2321      +86     
+ Partials      197      196       -1     
Impacted Files Coverage Δ
pkg/register/register.go 0.00% <0.00%> (ø)
pkg/register/state.go 0.00% <0.00%> (ø)
pkg/tpm/register.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Use explicit registration config and state file paths
- Skip registration update on (hardcoded) timer
- Use virtual filesystem where possible
@github-actions github-actions bot added area/tests test related changes area/build build related changes labels Jul 13, 2023
anmazzotti and others added 4 commits July 13, 2023 17:34
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
This commit stops using the ServiceAccount.Secrets list, as noted my
k8s this should not be used to find SA's associated secrets and this
is no longer being automatically managed by k8s since v1.24.

Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/operator operator related changes area/register register related changes area/tests test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants