Remove custom default config-dir on installation media #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
|
Draft as this requires some docs changes. |
kkaempf
approved these changes
Jul 27, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 48.51% 48.54% +0.02%
==========================================
Files 41 41
Lines 5322 5319 -3
==========================================
Hits 2582 2582
+ Misses 2523 2520 -3
Partials 217 217
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before having SeedImages resources this was handy, as the primary way of adding extra configurations during the installation was adding a
config.yamlwithin the ISO. Since ISOs are mostly customized within the cluster as part of the SeedImage built procedure, this is no longer handy and it even turns to be way too convoluted.