-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow machines reset #489
Allow machines reset #489
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 48.54% 51.50% +2.96%
==========================================
Files 41 41
Lines 5319 5551 +232
==========================================
+ Hits 2582 2859 +277
+ Misses 2520 2443 -77
- Partials 217 249 +32
☔ View full report in Codecov by Sentry. |
…cur" This reverts commit 7c98c53.
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
@anmazzotti I think we already clarified few little things on the chat and already stated some follow up little improvements that can be done later for which we already have issues created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job!
Resolves rancher/elemental#526
List of changes:
Reset
object toMachineRegistration
to customize reset behaviorelemental.cattle.io/resettable
annotation forMachineInventories
that can be resetMachineInventory
, so that a resettable machine will receive a reset plan to be executedelemental-system-agent
is no longer stopped and will continue to run to apply an eventual reset plan--reset
and--install
arguments forelemental-register
to decouple reset and installation workflows from registration updateselemental-register
now exploits the passedelemental install --config-urls
to inject/oem/registration/config.yaml
and/oem/registration/state.yaml
into an installed system