Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SLE Micro reference from elemental-operator images #491

Merged

Conversation

davidcassany
Copy link
Contributor

No description provided.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner August 1, 2023 14:31
@davidcassany davidcassany marked this pull request as draft August 1, 2023 14:31
@davidcassany
Copy link
Contributor Author

@fgiudici this is how I would tag the images from the chart. I would not include references to the SLE Micro version as those images are including really few things and they are really not related to any OS version. The same should apply for the channel images, ideally we should be capable to list images from multiple SLE Micro versions within the same image, hence adding a SLE Micro reference within the channel URI looks like a confusing idea to me. Only the OS images (and probably its helper images to build isos) should be clearly related to the underlaying SLE Micro version IMHO.

@kkaempf how do you feel about it?

@davidcassany
Copy link
Contributor Author

I'd like this to merge this after rancher/elemental-docs#187 as this also implies another URL change, but only for the next version.

@davidcassany davidcassany marked this pull request as ready for review August 2, 2023 09:36
@davidcassany
Copy link
Contributor Author

davidcassany commented Aug 2, 2023

Blocked waiting for rancher/elemental-docs#187

EDIT: Just realized the URL of those images is not appearing anywhere in docs (which is good, they are implementation details). My bad on assuming this PR was related somehow with rancher/elemental-docs#187.

Unblocking

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes ❤️

@davidcassany davidcassany merged commit 592b78d into rancher:main Aug 2, 2023
12 checks passed
@davidcassany davidcassany deleted the update_operator_image_references branch August 2, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants