-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and publish charts for OBS/IBS artifacts in gh-pages #499
Conversation
Signed-off-by: David Cassany <dcassany@suse.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 51.50% 51.50%
=======================================
Files 41 41
Lines 5551 5551
=======================================
Hits 2859 2859
Misses 2443 2443
Partials 249 249 ☔ View full report in Codecov by Sentry. |
6fef6b9
to
3194a16
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
3194a16
to
236d991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rework of the release process is quite nice!
LGTM - Looks Great To Me 😆
REGISTRY_URL?=quay.io/coostoolkit | ||
#REGISTRY_URL?=registry.opensuse.org/isv/rancher/elemental/dev/containers | ||
CHART_VERSION?=$(subst v,,$(GIT_TAG)) | ||
TAG?=${GIT_TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me TAG is no more used in the Makefile.
To be pedantic we may change this to TAG_OPERATOR?=${CHART_VERSION} and use it for the operator build (right now we use ${CHART_VERSION}).
Ok, maybe we could just drop TAG (even in the near future) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna take that into account on a follow up Makefile cleanup, looks like we can clean quite some stuff from this Makefile
This PR sets worflows to publish elemental-operator charts as github pages.
Currently there four different repositories defined in github pages:
Both stable and release repositories are build an published with the same workflow so they are aligned. That means we should only trigger this workflow once
suse.com
artifacts are on air, not before. In addition this workflow also creates a GH pre-release including the release charts tarball.In addition this PR also sets the e2e tests to make use of the container images build in OBS as part of the PR workflow. So this repository no longer pushes and pulls anything from
quay.io
.I named the repository pointing to
registry.suse.com
as release, however if anyone has a better name I'd be happy to change it, probably production or official ?There are still two follow up issues:
Fixes #460 and part of #333