Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish charts for OBS/IBS artifacts in gh-pages #499

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Aug 23, 2023

This PR sets worflows to publish elemental-operator charts as github pages.

Currently there four different repositories defined in github pages:

Both stable and release repositories are build an published with the same workflow so they are aligned. That means we should only trigger this workflow once suse.com artifacts are on air, not before. In addition this workflow also creates a GH pre-release including the release charts tarball.

In addition this PR also sets the e2e tests to make use of the container images build in OBS as part of the PR workflow. So this repository no longer pushes and pulls anything from quay.io.

I named the repository pointing to registry.suse.com as release, however if anyone has a better name I'd be happy to change it, probably production or official ?

There are still two follow up issues:

  • Moving to pure https helm repositories could break any automated elemental installation in place (e.g. our own CI), as helm has a different workflow if charts are coming from an http repo or from an OCI repo. Since this PR does not remove the OBS charts after merging nothing will break as both would be available. As a follow up we should remove the OBS ones and consider publishing also an OCI repository in github registry to facilitate migration by simply changing a URI on already existing setups.
  • I still believe there is a lot to clean from the Makefile and probably other bits and pieces from the former days where everything was build in github actions and released from there. We should remove all legacy and consider options for local builds and deployments.

Fixes #460 and part of #333

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany self-assigned this Aug 23, 2023
@davidcassany davidcassany requested a review from a team as a code owner August 23, 2023 13:51
@davidcassany davidcassany marked this pull request as draft August 23, 2023 13:51
@github-actions github-actions bot added the area/build build related changes label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1f3c32) 51.50% compared to head (f1c2891) 51.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   51.50%   51.50%           
=======================================
  Files          41       41           
  Lines        5551     5551           
=======================================
  Hits         2859     2859           
  Misses       2443     2443           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany force-pushed the gh_charts branch 20 times, most recently from 6fef6b9 to 3194a16 Compare August 24, 2023 14:45
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany marked this pull request as ready for review August 24, 2023 15:12
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rework of the release process is quite nice!
LGTM - Looks Great To Me 😆

.github/workflows/release-chart.yaml Show resolved Hide resolved
Makefile Show resolved Hide resolved
REGISTRY_URL?=quay.io/coostoolkit
#REGISTRY_URL?=registry.opensuse.org/isv/rancher/elemental/dev/containers
CHART_VERSION?=$(subst v,,$(GIT_TAG))
TAG?=${GIT_TAG}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me TAG is no more used in the Makefile.
To be pedantic we may change this to TAG_OPERATOR?=${CHART_VERSION} and use it for the operator build (right now we use ${CHART_VERSION}).
Ok, maybe we could just drop TAG (even in the near future) 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna take that into account on a follow up Makefile cleanup, looks like we can clean quite some stuff from this Makefile

Makefile Outdated Show resolved Hide resolved
@davidcassany davidcassany merged commit 7d89d3b into rancher:main Aug 28, 2023
14 checks passed
@davidcassany davidcassany deleted the gh_charts branch August 28, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sync the github Elemental Operator charts to what we have deliver on the Rancher Marketplace
3 participants