Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: drop chart version from resource labels #854

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

fgiudici
Copy link
Member

Fixes #846

@fgiudici fgiudici requested a review from a team as a code owner September 30, 2024 07:48
Fixes rancher#846

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the recommended labels: https://helm.sh/docs/chart_best_practices/labels/#standard-labels

It's fine to drop it for me if it breaks the marketplace, but I wonder why that is the case.
Also other marketplace charts use the same label, do they all have the same issue?

@fgiudici
Copy link
Member Author

fgiudici commented Sep 30, 2024

This is part of the recommended labels: https://helm.sh/docs/chart_best_practices/labels/#standard-labels

It's fine to drop it for me if it breaks the marketplace, but I wonder why that is the case. Also other marketplace charts use the same label, do they all have the same issue?

The issue is that Rancher chart versioning is in the form: 1.0.#+upX.Y.Z (charts version docs).
This is not a syntax allowed for Kubernetes Labels (the '+' character) 🤦🏼
For the other charts in the marketplace, yes, all have the same issue too... just checked, some hardcode the value to something else, others remove the "+" from the label's value... not sure at that point having something different than the chart real version makes sense 🤷🏼

@fgiudici fgiudici merged commit 4e313f7 into rancher:main Sep 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart version in the labels break Rancher Marketplace releases
2 participants