Dynamically set the URL template based on the build env #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
fix_UI_tests
branch
from
d363d83
to
5e7eabf
Compare
kkaempf
approved these changes
Aug 2, 2023
| @@ -388,7 +388,10 @@ Cypress.Commands.add('checkLabelSize', (sizeToCheck) => { | |||
|
|
|||
| // Add an OS version channel | |||
| Cypress.Commands.add('addOsVersionChannel', (channelVersion) => { | |||
| const channelRepo = `registry.opensuse.org/isv/rancher/elemental/${channelVersion}/containers/rancher/elemental-teal-channel/5.4:latest`; | |||
| let channelRepo = `registry.opensuse.org/isv/rancher/elemental/${channelVersion}/containers/rancher/elemental-teal-channel/5.4:latest`; | |||
There was a problem hiding this comment.
Hmm, this still has an embedded version number (5.4) 🤔
There was a problem hiding this comment.
Yes, I already created a CI card to address that here #940 this is a more generic issue within the CI, there are many references out there to the SLE Micro version. They should be limited and parametrized, I'd prefer to have Loic and Juilen around to address this, they might have opinions and good ideas about how to handle this.
There was a problem hiding this comment.
Also in relation to that there is also rancher/elemental-operator#491 which is about removing SLE Micro version references from images that are not explicitly based on SLE Micro for rancher (all but the OS images)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up of #939