Update helm-project-operator template values/helpers #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
force-pushed
the
fix-default-tag
branch
2 times, most recently
from
93eea81 to
33b69fc
Compare
mallardduck
force-pushed
the
fix-default-tag
branch
from
49181fd to
3fcfe00
Compare
joshmeranda
requested changes
Nov 25, 2024
| @@ -0,0 +1,64 @@ | |||
| #!/bin/bash | |||
mallardduck
commented
Nov 25, 2024
charts/prometheus-federator/0.4.4/charts/helmProjectOperator/templates/_helpers.tpl
Outdated
Show resolved
Hide resolved
charts/prometheus-federator/0.4.4/charts/helmProjectOperator/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
mallardduck
commented
Nov 25, 2024
| @@ -20,7 +20,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: {{ template "helm-project-operator.name" . }} | |||
| image: "{{ template "system_default_registry" . }}{{ .Values.image.repository }}:{{ .Values.image.tag }}" | |||
| image: "{{ template "helm-project-operator.imageRegistry" . }}{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | |||
There was a problem hiding this comment.
@joshmeranda - Felt like a function over complicated it, so I simplified to an inline default.
There was a problem hiding this comment.
I'm happy with either way as long as the right values are being redered. Since this is all done at render time anyway its not gonna have a real impact. Thanks!
joshmeranda
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#120
In an effort to improve the above issue, this PR makes a few changes:
Chart.yamlfile'sappVersion,values.yamlfile,The net result is that end users can still override tag values as they wish. However from a Dev POV we only have to maintain updating the
Chart.yamlversion as necessary.