Add chart Debug method #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images built for PR #138:
Helm Debug Values: image:
pullPolicy: Always
registry: ghcr.io
repository: rancher/prometheus-federator
tag: pr-138-36b409d |
mallardduck
force-pushed
the
charts-debug
branch
from
ad7477f to
b1fd904
Compare
alexandreLamarre
requested changes
Dec 18, 2024
mallardduck
force-pushed
the
charts-debug
branch
from
6be4a22 to
d849393
Compare
alexandreLamarre
approved these changes
Dec 19, 2024
pkg/debug/chart.go
Outdated
Comment on lines
18
to
20
| var ( | ||
| chartOnly bool | ||
| ) |
There was a problem hiding this comment.
This is a tip, not really review feedback, but you can actually define this variable in the ChartDebugCommand function too and have it work the same while making sure no one down the line wants to depend on or modify this variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, this PR adds method to debug the embedded chart inside of PromFed.
It's a lot easier to exec into the pod and run:
Which will save the chart to the
${CWD}/.debugfolder.