Max sure scale is set to 0 when autoscaling is set

rancher · Jun 12, 2019 · f7c4254 · f7c4254
1 parent 12724a4
commit f7c4254
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/cli/cmd/scale/scale.go b/cli/cmd/scale/scale.go
@@ -26,13 +26,20 @@ func (s *Scale) Run(ctx *clicontext.CLIContext) error {
 
 			if strings.ContainsRune(scaleStr, '-') {
 				min, max := kv.Split(scaleStr, "-")
-				minScale, _ := strconv.Atoi(min)
-				maxScale, _ := strconv.Atoi(max)
+				minScale, err := strconv.Atoi(min)
+				if err != nil {
+					return err
+				}
+				maxScale, err := strconv.Atoi(max)
+				if err != nil {
+					return err
+				}
 				if service.Spec.AutoscaleConfig.Concurrency == nil {
 					service.Spec.AutoscaleConfig.Concurrency = &[]int{10}[0]
 				}
 				service.Spec.AutoscaleConfig.MinScale = &minScale
 				service.Spec.AutoscaleConfig.MaxScale = &maxScale
+				service.Spec.Scale = 0
 			} else {
 				scale, err := strconv.Atoi(scaleStr)
 				if err != nil {