Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheusMetricsEnabled option to rke2-calico #368

Closed
wants to merge 1 commit into from
Closed

Add prometheusMetricsEnabled option to rke2-calico #368

wants to merge 1 commit into from

Conversation

vadossam
Copy link

Add to rke2-calico FelixConfiguration template prometheusMetricsEnabled option which is required for enabling metrics exporter.

@vadossam vadossam requested a review from a team as a code owner August 22, 2023 14:30
@brandond
Copy link
Member

cc @manuelbuil @thomasferrandiz

@rbrtbnfgl rbrtbnfgl mentioned this pull request Aug 25, 2023
Merged
@rbrtbnfgl
Copy link
Contributor

I created a new PR that should fix this and any new values that could be added on the felix config.

@brandond
Copy link
Member

@vadossam I think you can close this as superseded by #369

@vadossam vadossam closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@thomasferrandiz thomasferrandiz Awaiting requested review from thomasferrandiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadossam @brandond @rbrtbnfgl @manuelbuil