Added felixConfig values to be added from values.yaml file #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasferrandiz
approved these changes
Aug 25, 2023
Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
brandond
approved these changes
Aug 25, 2023
manuelbuil
reviewed
Aug 28, 2023
Comment on lines
-59
to
-60
| + failsafeInboundHostPorts: "" | ||
| + failsafeOutboundHostPorts: "" |
There was a problem hiding this comment.
If you remove these two, they will not be able to be set via helm
There was a problem hiding this comment.
Yes you can with the new logic you can specify whatever value you want through helm.
There was a problem hiding this comment.
ok, got it, thanks. The problem is that in Rancher UI, users will not be able to see what parameters can be changed, only the ones in values. So it is good if we keep the most common ones
manuelbuil
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the static values on
felixconfig.yamlto dynamically get them from thevalues.yamlfile to fix #368