Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CSI snapshot controller chart for CRD updates #7067

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 17, 2024

Proposed Changes

Update volume snapshot CRDs from upstream:
https://github.com/kubernetes-csi/external-snapshotter/tree/v8.1.0/client/config/crd

Major change is that most validation has been moved to CEL expressions instead of using the webhook.

Ref: rancher/rke2-charts#542

Types of Changes

CRD bump

Verification

Apply VolumeSnapshot with empty spec.volumeSnapshotClassName and receive error from validation rules:

The VolumeSnapshot "new-snapshot-demo" is invalid: spec.volumeSnapshotClassName: Invalid value: "string": volumeSnapshotClassName must not be the empty string when set

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner October 17, 2024 03:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.09%. Comparing base (f76a13f) to head (a7fe7f3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7067      +/-   ##
==========================================
+ Coverage   17.74%   25.09%   +7.35%     
==========================================
  Files          32       33       +1     
  Lines        2829     2841      +12     
==========================================
+ Hits          502      713     +211     
+ Misses       2285     2081     -204     
- Partials       42       47       +5     
Flag Coverage Δ
inttests 9.53% <ø> (?)
unittests 17.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit e789fa1 into rancher:master Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants