Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm quick-start guide for operator, turtles and rancher #12

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Aug 29, 2023

Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
… components

Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev marked this pull request as ready for review August 30, 2023 09:33
docs/getting-started/intro.md Outdated Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Outdated Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Show resolved Hide resolved
docs/getting-started/install_turtles_operator.md Outdated Show resolved Hide resolved
1. Installing in in the same cluster as the rancher manager.

Recommended path of installation for the operator is by using helm. To install it in your cluster you need to add repository first:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to covering how to install it via the Rancher Manager UI as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already covered in #19

| Name | Version | Details |
| ------------------------ | ---------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also i think we need a banner saying that this is for early adopters only at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a mention of early adopters contact in the table, should it lead somewhere specific?

docs/getting-started/rancher.md Outdated Show resolved Hide resolved
docs/tasks/capi-operator/add_infrastructure_provider.md Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev force-pushed the quickstart-operator branch 2 times, most recently from 9d39ffc to 4bc0010 Compare August 31, 2023 11:08
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Danil-Grigorev 🎉

docs/getting-started/install_capi_operator.md Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Outdated Show resolved Hide resolved
docs/getting-started/install_turtles_operator.md Outdated Show resolved Hide resolved
docs/getting-started/rancher.md Outdated Show resolved Hide resolved
docs/getting-started/rancher.md Outdated Show resolved Hide resolved
docs/getting-started/rancher.md Outdated Show resolved Hide resolved
docs/getting-started/rancher.md Outdated Show resolved Hide resolved
docs/tasks/capi-operator/add_infrastructure_provider.md Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev force-pushed the quickstart-operator branch 2 times, most recently from 8d4d87c to 2498461 Compare September 4, 2023 20:49
docs/getting-started/install_capi_operator.md Outdated Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Outdated Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Outdated Show resolved Hide resolved
This section describes how an infrastructure provider such as `Azure` could be added using `Cluster API Operator`.

### Installing Azure Infrastructure Provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we refer to the capi operator docs instead of duplicating it? My concern is, keeping this up-to-date with capi operator docs might be challenging in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always pin it to a version of the operator docs to use, and the docs are describing a fixed state of some release of operator and turtles IMO. Additionally the value of the documentation is in simple access to the most common use cases in a single unified location. We may explore some better documentation options for the CAPI Operator, as a single README.md file is quite inconvenient to always refer to. It could clearly be separated into multiple sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for deduplicating

@Danil-Grigorev Danil-Grigorev force-pushed the quickstart-operator branch 2 times, most recently from 0c452fc to 0d490e5 Compare September 5, 2023 08:14
- Add secrions for the CAPI operator installation as a dependency

Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
docs/getting-started/install_capi_operator.md Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Show resolved Hide resolved
docs/getting-started/install_capi_operator.md Show resolved Hide resolved
docs/getting-started/install_turtles_operator.md Outdated Show resolved Hide resolved
This section describes how an infrastructure provider such as `Azure` could be added using `Cluster API Operator`.

### Installing Azure Infrastructure Provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for deduplicating

Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in. We can they do a complete review of all the docs

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions for the future reference when we re-iterate over

This section describes how to install `Cluster API Operator` in the Kubernetes cluster.

## Installing CAPI and providers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Installing CAPI and providers
## Installing Cluster API (CAPI) and providers


### Install manually with Helm (alternative)
To install `Cluster API Operator` with version `1.4.6` of the `CAPI` + `Docker` provider using helm, follow these steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth mentioning why we are using specific CAPI version, v1.4.6 in this case and later versions of it can be used in the future due to some limitations of the Rancher ?

helm repo add capi-operator https://kubernetes-sigs.github.io/cluster-api-operator
```
2. Update the Helm repository by running the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Update the Helm repository by running the following command:
2. Update the Helm repository:

helm repo update
```
3. Install the `Cluster API Operator` using the following command, which will also install `cert-manager`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Install the `Cluster API Operator` using the following command, which will also install `cert-manager`:
3. Install the `Cluster API Operator`, which will also install `cert-manager`:

--timeout 90s --wait # Core Cluster API with kubeadm bootstrap and control plane providers will also be installed
```
*Note: `cert-manager` is a hard requirement for CAPI and `Cluster API Operator`*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Note: `cert-manager` is a hard requirement for CAPI and `Cluster API Operator`*
*Note: `cert-manager` is a hard requirement for `CAPI`and `Cluster API Operator`*

```

The `infrastructure` flag is set to `docker:v1.4.6;azure:v1.4.6`, representing the desired provider names. This means that the `Cluster API Operator` will install and manage multiple provider systems, `Docker` and `Azure` respectively, with versions `1.4.6` specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `infrastructure` flag is set to `docker:v1.4.6;azure:v1.4.6`, representing the desired provider names. This means that the `Cluster API Operator` will install and manage multiple provider systems, `Docker` and `Azure` respectively, with versions `1.4.6` specified.
The `infrastructure` flag is set to `docker:v1.4.6;azure:v1.4.6`, representing the desired provider names. This means that the `Cluster API Operator` will install and manage multiple providers, `Docker` and `Azure` respectively, with versions `v1.4.6` specified in this example.

*Note: In the future, we will support different deployment topologies*

The recommended path of installation for the operator is by using `Helm`. To install it in the cluster, a repository should be added first:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The recommended path of installation for the operator is by using `Helm`. To install it in the cluster, a repository should be added first:
The recommended path of installation for the operator is by using `Helm`. To install it in the cluster, a chart repository should be added first:

*Note: this section will be extended with additional details later*

A `rancher-turtles` repository should be added first:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A `rancher-turtles` repository should be added first:
A `rancher-turtles` chart repository should be added first:

### Deleting providers

To remove the installed providers and all related kubernetes objects just delete the following CRs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To remove the installed providers and all related kubernetes objects just delete the following CRs:
To remove the installed providers and all related Kubernetes objects, just delete the following CRs:


# Basic Cluster API Provider Installation

This section describes the basic process of installing `CAPI` providers using the operator. The `Cluster API Operator` manages five types of objects:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This section describes the basic process of installing `CAPI` providers using the operator. The `Cluster API Operator` manages five types of objects:
This section describes the basic process of installing `CAPI` providers using the operator. The `Cluster API Operator` manages five types of provider objects:

@Danil-Grigorev Danil-Grigorev merged commit 222a1bd into rancher:main Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started guide - base Getting started guide - install new CAPI providers
4 participants