🌱 Add turtlesnaming to linter package #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
added
the
kind/cleanup
4 tasks
furkatgofurov7
requested changes
Sep 12, 2023
| alias: provisioningv1 | ||
| - pkg: github.com/rancher-sandbox/rancher-turtles/internal/rancher/management/v3 | ||
| alias: managementv3 | ||
| alias: turtlesnaming |
There was a problem hiding this comment.
remove this, otherwise LGTM
Danil-Grigorev
force-pushed
the
add-turtlesnaming-to-lint
branch
from
ea5a5af
to
028feca
Compare
Co-authored-by: Furkat Gofurov <furkat.gofurov@suse.com> Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
add-turtlesnaming-to-lint
branch
from
028feca
to
49af348
Compare
furkatgofurov7
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/cleanup
What this PR does / why we need it:
Adding per review comment #84 (review)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: