Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch CAPI cluster after reconciling it #68

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

We set an annotation on cluster delete but we don't patch CAPI cluster so the change is reflected.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev added the kind/bug Something isn't working label Aug 9, 2023
@alexander-demicev alexander-demicev requested a review from a team as a code owner August 9, 2023 13:28
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it!

@alexander-demicev alexander-demicev merged commit 2c8271c into rancher:main Aug 9, 2023
8 checks passed
@alexander-demicev alexander-demicev deleted the patchcapicluster branch August 9, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants