Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new issue template for provider certification #681

Conversation

salasberryfin
Copy link
Contributor

What this PR does / why we need it:

As part of provider certification, this adds a new issue template for requesting a provider to be added to the list of Certified Providers once it is validated. This can be interesting for certain providers that we're not able to validate ourselves but users may be interested in using. After they certify the providers themselves,they can request it be added to the list and we can decide whether the provider is worth adding the main E2E suite so that it can be added to the Certified Table in the docs.

Which issue(s) this PR fixes:
Fixes #680

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some questions/suggestions inline:

.github/ISSUE_TEMPLATE/certification_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/certification_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/certification_request.yaml Outdated Show resolved Hide resolved
@salasberryfin salasberryfin force-pushed the issue-template-request-provider-certification branch from 870b80f to 2ff21d1 Compare August 22, 2024 10:27
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin salasberryfin force-pushed the issue-template-request-provider-certification branch from 2ff21d1 to a30a7ab Compare August 22, 2024 10:29
@salasberryfin
Copy link
Contributor Author

Thanks for the comments @furkatgofurov7. PR is updated and ready to be reviewed again.

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@salasberryfin salasberryfin merged commit d74ef8c into rancher:main Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new issue template for provider certification
3 participants