🌱 Use utilyaml to collect agent manifests in remote cluster #71
Conversation
Danil-Grigorev
added
the
kind/cleanup
Danil-Grigorev
force-pushed
the
use-capi-unstructured-util
branch
from
a60da79
to
0b70bac
Compare
| Name: obj.GetName(), | ||
| }, u) | ||
| err := c.Create(ctx, obj) | ||
| if client.IgnoreAlreadyExists(err) != nil { |
There was a problem hiding this comment.
Whats the difference between this check and the apierrors.IsAlreadyExists below?
There was a problem hiding this comment.
The first one filters out the AlreadyExists error, and returns all other error types or nil. The other one specifically checks for the error being of type AlreadyExist. I hoped this will be more readable, but may be it isn’t. Can change to err != nil for the second one, it is equivalent.
There was a problem hiding this comment.
we could move maybe this:
if apierrors.IsAlreadyExists(err) {} up to check for api errors and later check for err != nil since it will be not api errors anymore?
There was a problem hiding this comment.
I’ve updated the implementation. Though this change brings no functional difference, just the code style.
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
use-capi-unstructured-util
branch
from
0b70bac
to
2cf0595
Compare
kind/cleanup
What this PR does / why we need it:
Using CAPI utilyaml to collect and apply raw manifests from import endpoint.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: