Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e-long-test in EIO provided Containerized Org-Level Runners #711

Closed

Conversation

furkatgofurov7
Copy link
Contributor

What this PR does / why we need it:
e2e long tests are stuck waiting for GH runner to be picked up and eventually timing out (after a long waiting): https://github.com/rancher/turtles/actions/workflows/e2e-long.yaml

This PR tries to move only e2e-long-tests to be run in EIO provided Containerized Org-Level Runners (xref: https://github.com/rancherlabs/eio/wiki/GitHub-Actions-Runners#containerized-org-level-runners). All the other GH workflows as of now are currently using public provided GH runners.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner September 2, 2024 08:12
@furkatgofurov7
Copy link
Contributor Author

furkatgofurov7 commented Sep 2, 2024

Testing EIO provided Containerized Org-Level Runners in short tests (1d0f2a9, will be dropped after testing) to see how it behaves before moving e2e-long tests since the latter can't be tested prior to merging.

@alexander-demicev
Copy link
Member

@furkatgofurov7 are these containerized runners going to be sufficient for running CAPD suite?

@furkatgofurov7
Copy link
Contributor Author

@furkatgofurov7 are these containerized runners going to be sufficient for running CAPD suite?

@alexander-demicev which tests exactly are you referring to? I just run e2e short tests on this one and they passed.

@alexander-demicev
Copy link
Member

We're not running CAPRKE2 + CAPD at the moment in the short run

@furkatgofurov7
Copy link
Contributor Author

@furkatgofurov7 are these containerized runners going to be sufficient for running CAPD suite?

@alexander-demicev which tests exactly are you referring to? I just run e2e short tests on this one and they passed.

true, however they are not running at all for now (https://github.com/rancher/turtles/pull/634/files) and even they were, there is no way to run them on PR.

@furkatgofurov7
Copy link
Contributor Author

After an offline discussion within the team, there is no rush on moving to EIO hosted runners at least for now, since we have our custom runners running for each suite configured/managed by our team in GCP. As per the current issues of not running e2e long tests, that was resolved by @alexander-demicev by renewing the tokens needed for the runners to properly run. We might re-consider moving to EIO runners in the future though, but for now this change can be postponed.

@furkatgofurov7 furkatgofurov7 deleted the run-longe2e-in-eiorunners branch September 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants