Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ClusterctlConfig with controller #742

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner September 12, 2024 13:53
@Danil-Grigorev Danil-Grigorev changed the title Implement ClusterctlConfig with controleler Implement ClusterctlConfig with controller Sep 12, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the clusterctl-config-controller branch 7 times, most recently from 4ef2bea to 34980a3 Compare September 16, 2024 08:37
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev
Copy link
Contributor Author

Danil-Grigorev commented Sep 19, 2024

I’d like to follow up with the changes in the next PR, ensuring CAPIProvider will maintain latest version from the in-memory state, including cleanup and refactoring.

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment that needs resolving, otherwise LGTM

@alexander-demicev alexander-demicev merged commit 0070e17 into rancher:main Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants