ADR: Running out of Rancher Manager cluster #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
changed the title
4 tasks
salasberryfin
added
the
kind/documentation
salasberryfin
force-pushed
the
out-of-cluster-adr
branch
from
ecaf4e6
to
24fee4b
Compare
Danil-Grigorev
previously approved these changes
Aug 31, 2023
richardcase
reviewed
Aug 31, 2023
salasberryfin
force-pushed
the
out-of-cluster-adr
branch
2 times, most recently
from
e2ecb37
to
b15f542
Compare
|
Thanks for the reviews @richardcase @furkatgofurov7 @Danil-Grigorev. I updated the proposal and also used |
salasberryfin
requested review from
richardcase,
furkatgofurov7 and
Danil-Grigorev
furkatgofurov7
previously approved these changes
Sep 4, 2023
alexander-demicev
previously approved these changes
Sep 4, 2023
salasberryfin
dismissed stale reviews from alexander-demicev and furkatgofurov7
via
5174e8b
salasberryfin
force-pushed
the
out-of-cluster-adr
branch
from
b15f542
to
5174e8b
Compare
furkatgofurov7
approved these changes
Sep 4, 2023
alexander-demicev
approved these changes
Sep 4, 2023
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
out-of-cluster-adr
branch
from
5174e8b
to
024136d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/documentation
What this PR does / why we need it:
Adds ADR for running Rancher Turtles out of Rancher Manager cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #94
Special notes for your reviewer:
Checklist: