Validate LastUsedAt for Token and ClusterAuthToken #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobby
previously approved these changes
Oct 8, 2024
andreas-kupries
previously approved these changes
Oct 8, 2024
ericpromislow
previously approved these changes
Oct 8, 2024
pmatseykanets
dismissed stale reviews from ericpromislow, andreas-kupries, and crobby
via
d4fd383
pmatseykanets
force-pushed
the
validate-token-lastusedat
branch
from
db74631
to
6d59d44
Compare
andreas-kupries
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#45732
Related work
This is #480 (re)opened against the main branch. An original PR was opened against and erroneously merged to release/v0.5.
Problem
A new optional field
lastUsedAtwas added to Token and ClusterAuthToken of typemetav1.Time.Solution
Validate that if set the
lastUsedAtfield of Token and ClusterAuthToken contains a valid RFC3339 date time value.CheckList