Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Namespaced scope for ClusterAuthToken validator #522

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Use Namespaced scope for ClusterAuthToken validator #522

merged 1 commit into from
Oct 16, 2024

Conversation

pmatseykanets
Copy link
Contributor

@pmatseykanets pmatseykanets commented Oct 15, 2024 •
edited
Loading

Issue:

rancher/rancher#45732

Problem

The ClusterAuthToken is a namespaced resource but the validator configuration had the scope set to Cluster. As a consequence the webhook hasn't been called on changes in ClusterAuthTokens.

Solution

Set the scope to Namespaced for ClusterAuthToken.

CheckList

  • Test
  • Docs

@pmatseykanets pmatseykanets self-assigned this Oct 15, 2024
@pmatseykanets pmatseykanets requested a review from a team as a code owner October 15, 2024 17:48
@pmatseykanets pmatseykanets merged commit 8d0a593 into rancher:main Oct 16, 2024
2 checks passed
@pmatseykanets pmatseykanets deleted the fix-clusterauthtoken-validator-config branch October 16, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobby crobby crobby approved these changes

@JonCrowther JonCrowther JonCrowther approved these changes

@maxsokolovsky maxsokolovsky maxsokolovsky approved these changes

@tomleb tomleb Awaiting requested review from tomleb

Assignees

@pmatseykanets pmatseykanets

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmatseykanets @crobby @JonCrowther @maxsokolovsky