Straydogstudio master

[randym]

• bakes in a few version switches (yuck!) so that we can be compatible with AR 2.3, 3.1, and 4.1
• removes support for ruby 1.8.7
• adds support for where/order options for folks who are over 3.0
• adds skip_humanization option to directly output the table and column names exactly.

TODO
[] Confirm docs/version bump
[] Manual testing
[] merge and ship

[straydogstudio]

Looks great.

I would not try to extract version checking into one place. In the runtime code it is only in one place. And from what I know it is not a problem to repeat code in tests, especially if it makes things clearer. KISS doesn't always apply. So my vote is to leave the version checking as is.

Are you wanting the extra tests before you merge?

[randym]

Less about KISS, more about SRP. That method is extremely busy. I'll extract the record to row data conversions and label generation and toss in some specs for revue later tonight.

[straydogstudio]

Sounds good. Let me know if you want any help.

[ricardodovalle]

@straydogstudio any news about PR?

[jhcasado]

pleeeease 👍

[straydogstudio]

@jhcasado @ricardodovalle I think we are waiting for @randym or another (e.g. myself) to finish the TODO list above. In the meantime, you can use my branch just to survive:

https://github.com/straydogstudio/acts_as_xlsx

It is not as robust as this pull request, but it works for now.

[ricardodovalle]

@straydogstudio , I've been using your branch in production already.

Thank you very much. 👍

[jhcasado]

Yeah, works like a charm, thx @straydogstudio 👏

[straydogstudio]

@randym Have you looked into this issue since last year?