Avoid losing a host when adding to retry service hector-client#439

rantav · Mar 17, 2012 · 7055e9f · 7055e9f
1 parent db74f37
commit 7055e9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -11,6 +11,7 @@ See object-mapper/CHANGELOG for HOM specifics
 Made Composite Serializable
 Added Composite to TypeInferringSerializer
 Add start key to KeyIterator #419
+Fix losing a host during Retry Down host service #439
 
 1.0-3
 =====

diff --git a/core/src/main/java/me/prettyprint/cassandra/connection/CassandraHostRetryService.java b/core/src/main/java/me/prettyprint/cassandra/connection/CassandraHostRetryService.java
@@ -72,8 +72,9 @@ public void add(final CassandraHost cassandraHost) {
       @Override
       public void run() {
         if(downedHostQueue.contains(cassandraHost) && verifyConnection(cassandraHost)) {
-          connectionManager.addCassandraHost(cassandraHost);
-          downedHostQueue.remove(cassandraHost);
+          if (connectionManager.addCassandraHost(cassandraHost)) {
+            downedHostQueue.remove(cassandraHost);
+          }
           return;
         }
       }