Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use go-moolticute package #19

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliverpool
Copy link

Follow-up of raoulh/mc-cli#8 (comment), to have some code to discuss about.

I am using some features from go1.13 regarding error handling, but I can refactor it if you prefer.

@raoulh
Copy link
Owner

raoulh commented Dec 7, 2021

thanks, I will need some time to review and test everything. I'm a bit busy right now

@oliverpool
Copy link
Author

I have have a WIP for a simpler ssh agent: https://git.sr.ht/~oliverpool/go-moolticute/tree/agent

It works (mc-agent -- ssh-add -L to list the identities for instance), but it needs some polishing to arrive at feature-parity.

It "simply" implements the agent.Agent interface (code mostly copied from agent.NewKeyring) and leverages agent.ServeAgent for the wiring.

The customization is at the end: https://git.sr.ht/~oliverpool/go-moolticute/tree/agent/item/ssh/agent.go#L316

I will be on holidays for the next two weeks, so not working further on it until January 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants