Adds minor code optimisation

raphaelstolt · May 14, 2024 · d365d1e · d365d1e
1 parent 0c7e9ac
commit d365d1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/app/Domain/PackageAnalyser.php b/app/Domain/PackageAnalyser.php
@@ -12,8 +12,6 @@
 
 class PackageAnalyser
 {
-    private string $directoryToAnalyse;
-
     private array $steps;
 
     private array $stepIds;
@@ -23,10 +21,8 @@ class PackageAnalyser
     /**
      * @throws NonExistentPackageDirectory
      */
-    public function __construct(string $directoryToAnalyse)
+    public function __construct(readonly string $directoryToAnalyse)
     {
-        $this->directoryToAnalyse = $directoryToAnalyse;
-
         if (! file_exists($directoryToAnalyse)) {
             $exceptionMessage = sprintf("Provided package directory '%s' does not exist.", $directoryToAnalyse);
             throw new NonExistentPackageDirectory($exceptionMessage);

diff --git a/app/Domain/ReportWriter.php b/app/Domain/ReportWriter.php
@@ -13,13 +13,10 @@ class ReportWriter
 
     private string $directoryAnalysed;
 
-    private string $outputDirectory;
-
-    public function __construct(PackageAnalyser $analyser, string $outputDirectory)
+    public function __construct(PackageAnalyser $analyser, readonly string $outputDirectory)
     {
         $this->analyseSteps = $analyser->getSteps();
         $this->directoryAnalysed = $analyser->getDirectoryToAnalyse();
-        $this->outputDirectory = $outputDirectory;
     }
 
     public function write(): bool