Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark rpc_meterpreter_read as deprecated #19019

Open
adfoster-r7 opened this issue Mar 27, 2024 · 1 comment
Open

Mark rpc_meterpreter_read as deprecated #19019

adfoster-r7 opened this issue Mar 27, 2024 · 1 comment
Labels
breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. suggestion-feature New feature suggestions

Comments

@adfoster-r7
Copy link
Contributor

Summary

We'll be introducing a new RPC method for generically making interactive read/write calls to session types such as Meterpreter/SMB/SQL/etc

We want to deprecate and remove the old method:

module RPC
class RPC_Session < RPC_Base

  def initialize(service)
    @deprecator = ActiveSupport::Deprecation.new('7.1', 'metasploit-framework')
    @deprecator.deprecate_methods(
      self.class,
      rpc_meterpreter_read: :rpc_interactive_read,
      rpc_meterpreter_write: :rpc_interactive_write
    )
    super(service)
  end

Motivation

We don't want to immediately remove this method or mark it as deprecated, as it would impact tooling that may not receive future updates (armitage).

@adfoster-r7 adfoster-r7 added the breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. label Mar 27, 2024
Copy link

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

@github-actions github-actions bot added the Stale Marks an issue as stale, to be closed if no action is taken label Apr 29, 2024
@adfoster-r7 adfoster-r7 added suggestion-feature New feature suggestions and removed Stale Marks an issue as stale, to be closed if no action is taken labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. suggestion-feature New feature suggestions
Projects
None yet
Development

No branches or pull requests

1 participant