-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the new DNS command #18868
Conversation
|
||
## The DNS command | ||
Metasploit's DNS configuration is controlled by the `dns` command which has multiple subcommands. This command is only | ||
available when the `dns_feature` is enabled (`set feature dns_feature true`). Once enabled, the current configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's implied here but maybe explicitly mention that the dns_feature
by default is disabled.
Also does the dns_feature
require a database to be connected to metasploit? If so it might be worth mentioning that here.
dns add --rule * static system 192.0.2.1 | ||
``` | ||
|
||
Define a rule in the first position to handle all queries for `*.lab.lan` using an upstream server contacted through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it defined in the first position? I was under the impression --index
should be used to add a rule in a specific position.
Also, the example specifies an upstream DNS server (192.0.2.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, the text should be updated to note that the default behavior is to append the rule to the end.
Thanks @zeroSteiner ! Everything looks good now. I'll go ahead and land it. |
Release NotesThis adds documentation for the new DNS command. |
This adds documentation to the site for the new DNS command as added in #18809.
Verification
List the steps needed to make sure this thing works