Revert "Sql sessions have correct history manager" #19113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this has been confirmed to be the history for crashing Kali/Ubuntu instances; We'll roll forward with a revert - and have a separate fix to bring back the history limiting logic that got lost here: https://github.com/rapid7/metasploit-framework/pull/18933/files#r1572614863 |
Release NotesFixes a regression that caused Metasploit to leak memory, and sometimes crash |
|
cc @daniruiz - just a heads up that we've shipped an out of band release for fixing an msfconsole crash that Kali users were running into over here: #19098 I'm not sure what way the issue triaging works for Kali, but the crash should be fixed in this tagged release https://github.com/rapid7/metasploit-framework/releases/tag/6.4.5 - and we also have a workaround here: #19098 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #18933 - relates to the memory leak spotted here: #19098
Which may be causing memory issues here: #19098