Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EVENT_DEPENDENT to vcenter vmon priv esc #19122

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Apr 22, 2024

Now that #17294 has landed, add the new EVENT_DEPENDENT to one of the modules which needed it.

Verification

  • Start msfconsole
  • use vcenter_java_wrapper
  • info
  • Verify event-dependent is in reliability list

@@ -51,7 +51,7 @@ def initialize(info = {})
},
'Notes' => {
'Stability' => [CRASH_SERVICE_DOWN],
'Reliability' => [REPEATABLE_SESSION],
'Reliability' => [REPEATABLE_SESSION, EVENT_DEPENDENT],
Copy link
Contributor

@adfoster-r7 adfoster-r7 Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding - is this referring to just a computer restart, or something else? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Apr 22, 2024

Looks like we'll have to add the new value to the validation tests here:

#
# Acceptable Reliability ratings
#
VALID_RELIABILITY_VALUES = [
Msf::FIRST_ATTEMPT_FAIL,
Msf::REPEATABLE_SESSION,
Msf::UNRELIABLE_SESSION
]

If you throw that in, hopefully CI passes 🤞 If not, I'll fix whatever else is needed as a separate PR

@adfoster-r7
Copy link
Contributor

Should be the final change:

diff --git a/spec/module_validation_spec.rb b/spec/module_validation_spec.rb
index 1a1c819110..fbf53d08a6 100644
--- a/spec/module_validation_spec.rb
+++ b/spec/module_validation_spec.rb
@@ -107,7 +107,7 @@ RSpec.describe ModuleValidation::Validator do
       end
 
       it 'has errors' do
-        expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session"] is allowed']
+        expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session", "event-dependent"] is allowed']
       end
     end

Or let me know if you want me to sort it out without any extra overhead on your end - sorry about that!

@h00die
Copy link
Contributor Author

h00die commented Apr 23, 2024

I won't be able to get to it for about 24hrs, so you'll likely have a quicker shot at it

@adfoster-r7 adfoster-r7 merged commit 718cc0f into rapid7:master Apr 23, 2024
34 checks passed
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Apr 23, 2024

Release Notes

Adds additional reliability metadata to exploits/linux/local/vcenter_java_wrapper_vmon_priv_esc

@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Apr 23, 2024
@h00die h00die deleted the event branch April 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants