-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EVENT_DEPENDENT to vcenter vmon priv esc #19122
Conversation
@@ -51,7 +51,7 @@ def initialize(info = {}) | |||
}, | |||
'Notes' => { | |||
'Stability' => [CRASH_SERVICE_DOWN], | |||
'Reliability' => [REPEATABLE_SESSION], | |||
'Reliability' => [REPEATABLE_SESSION, EVENT_DEPENDENT], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding - is this referring to just a computer restart, or something else? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we'll have to add the new value to the validation tests here: metasploit-framework/spec/support/lib/module_validation.rb Lines 63 to 70 in a554e52
If you throw that in, hopefully CI passes 🤞 If not, I'll fix whatever else is needed as a separate PR |
Should be the final change: diff --git a/spec/module_validation_spec.rb b/spec/module_validation_spec.rb
index 1a1c819110..fbf53d08a6 100644
--- a/spec/module_validation_spec.rb
+++ b/spec/module_validation_spec.rb
@@ -107,7 +107,7 @@ RSpec.describe ModuleValidation::Validator do
end
it 'has errors' do
- expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session"] is allowed']
+ expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session", "event-dependent"] is allowed']
end
end Or let me know if you want me to sort it out without any extra overhead on your end - sorry about that! |
I won't be able to get to it for about 24hrs, so you'll likely have a quicker shot at it |
Release NotesAdds additional reliability metadata to |
Now that #17294 has landed, add the new
EVENT_DEPENDENT
to one of the modules which needed it.Verification
msfconsole
use vcenter_java_wrapper
info
event-dependent
is in reliability list